no additional ipv4/6 configuration when disabled - #24
Open
kbucheli wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Do you find a minute or two to look at this pull request? |
Owner
|
Thank you for your reminder. We will look at it when we have time. |
kbucheli
force-pushed
the
minimal_disabled_config
branch
from
January 27, 2025 15:42
a18b4d6 to
b5377e4
Compare
Collaborator
|
I will test this and merge it if ti is OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
ipv4andipv6configuration hash generation into a own function each.In these functions additional configuration is only attached if the respective family is enabled.
On my test node (using only connection resources :-( ) I get now no additional configuration except that IPv4 and IPv6 are disabled.